ata: ahci_xgene: free structure returned by acpi_get_object_info()
authorMichał Kępień <kernel@kempniu.pl>
Thu, 5 Jan 2017 14:14:01 +0000 (15:14 +0100)
committerTejun Heo <tj@kernel.org>
Fri, 6 Jan 2017 16:39:14 +0000 (11:39 -0500)
acpi_get_object_info() allocates the returned structure, which the
caller has to free when the call succeeds.  Free it when appropriate.

Fixes: c9802a4be661 ("ata: ahci_xgene: Add AHCI Support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller.")
Signed-off-by: Michał Kępień <kernel@kempniu.pl>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/ahci_xgene.c

index 73b19b2..c2b5941 100644 (file)
@@ -821,8 +821,10 @@ static int xgene_ahci_probe(struct platform_device *pdev)
                                dev_warn(&pdev->dev, "%s: Error reading device info. Assume version1\n",
                                        __func__);
                                version = XGENE_AHCI_V1;
-                       } else if (info->valid & ACPI_VALID_CID) {
-                               version = XGENE_AHCI_V2;
+                       } else {
+                               if (info->valid & ACPI_VALID_CID)
+                                       version = XGENE_AHCI_V2;
+                               kfree(info);
                        }
                }
        }