gpio: mvebu: make pwm .get_state closer to idempotent
authorBaruch Siach <baruch@tkos.co.il>
Wed, 20 Jan 2021 16:16:26 +0000 (18:16 +0200)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Mon, 15 Feb 2021 10:43:30 +0000 (11:43 +0100)
Round up the divisions in .get_state() to make applying the read out
configuration idempotent in most cases as .apply rounds down.

Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-mvebu.c

index c424d88..8673ba7 100644 (file)
@@ -668,7 +668,7 @@ static void mvebu_pwm_get_state(struct pwm_chip *chip,
 
        regmap_read(mvpwm->regs, mvebu_pwmreg_blink_on_duration(mvpwm), &u);
        val = (unsigned long long) u * NSEC_PER_SEC;
-       do_div(val, mvpwm->clk_rate);
+       val = DIV_ROUND_UP_ULL(val, mvpwm->clk_rate);
        if (val > UINT_MAX)
                state->duty_cycle = UINT_MAX;
        else if (val)
@@ -680,7 +680,7 @@ static void mvebu_pwm_get_state(struct pwm_chip *chip,
        regmap_read(mvpwm->regs, mvebu_pwmreg_blink_off_duration(mvpwm), &u);
        val += (unsigned long long) u; /* period = on + off duration */
        val *= NSEC_PER_SEC;
-       do_div(val, mvpwm->clk_rate);
+       val = DIV_ROUND_UP_ULL(val, mvpwm->clk_rate);
        if (val > UINT_MAX)
                state->period = UINT_MAX;
        else if (val)