Staging: comedi: fix printk issue in pcmuio.c
authorRavishankar karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Mon, 12 Dec 2011 05:19:18 +0000 (10:49 +0530)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 14 Dec 2011 00:25:00 +0000 (16:25 -0800)
This is a patch to the pcmuio.c file that fixes up a printk
warning found by the checkpatch.pl tool.

Converted printks to dev_functions.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/comedi/drivers/pcmuio.c

index 0c5b06d..41f843b 100644 (file)
@@ -295,15 +295,15 @@ static int pcmuio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
        irq[0] = it->options[1];
        irq[1] = it->options[2];
 
-       printk("comedi%d: %s: io: %lx ", dev->minor, driver.driver_name,
-              iobase);
+       dev_dbg(dev->hw_dev, "comedi%d: %s: io: %lx attached\n", dev->minor,
+               driver.driver_name, iobase);
 
        dev->iobase = iobase;
 
        if (!iobase || !request_region(iobase,
                                       thisboard->num_asics * ASIC_IOSIZE,
                                       driver.driver_name)) {
-               printk("I/O port conflict\n");
+               dev_err(dev->hw_dev, "I/O port conflict\n");
                return -EIO;
        }
 
@@ -318,7 +318,7 @@ static int pcmuio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
  * convenient macro defined in comedidev.h.
  */
        if (alloc_private(dev, sizeof(struct pcmuio_private)) < 0) {
-               printk("cannot allocate private data structure\n");
+               dev_warn(dev->hw_dev, "cannot allocate private data structure\n");
                return -ENOMEM;
        }
 
@@ -337,7 +337,7 @@ static int pcmuio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
            kcalloc(n_subdevs, sizeof(struct pcmuio_subdev_private),
                    GFP_KERNEL);
        if (!devpriv->sprivs) {
-               printk("cannot allocate subdevice private data structures\n");
+               dev_warn(dev->hw_dev, "cannot allocate subdevice private data structures\n");
                return -ENOMEM;
        }
        /*
@@ -348,7 +348,7 @@ static int pcmuio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
         * 96-channel version of the board.
         */
        if (alloc_subdevices(dev, n_subdevs) < 0) {
-               printk("cannot allocate subdevice data structures\n");
+               dev_dbg(dev->hw_dev, "cannot allocate subdevice data structures\n");
                return -ENOMEM;
        }