media: coda: Print a nicer device registered message
authorEzequiel Garcia <ezequiel@collabora.com>
Thu, 2 May 2019 22:00:42 +0000 (18:00 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 28 May 2019 16:20:53 +0000 (12:20 -0400)
This is just a cosmetic change to print a more descriptive
message, to distinguish decoder from encoder:

So, instead of printing

  coda 2040000.vpu: codec registered as /dev/video[4-5]

With this change, the driver now prints

  coda 2040000.vpu: encoder registered as /dev/video4
  coda 2040000.vpu: decoder registered as /dev/video5

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/coda/coda-common.c

index 614943e..3f028d1 100644 (file)
@@ -2507,9 +2507,12 @@ err_clk_per:
 static int coda_register_device(struct coda_dev *dev, int i)
 {
        struct video_device *vfd = &dev->vfd[i];
+       enum coda_inst_type type;
+       int ret;
 
        if (i >= dev->devtype->num_vdevs)
                return -EINVAL;
+       type = dev->devtype->vdevs[i]->type;
 
        strscpy(vfd->name, dev->devtype->vdevs[i]->name, sizeof(vfd->name));
        vfd->fops       = &coda_fops;
@@ -2525,7 +2528,12 @@ static int coda_register_device(struct coda_dev *dev, int i)
        v4l2_disable_ioctl(vfd, VIDIOC_G_CROP);
        v4l2_disable_ioctl(vfd, VIDIOC_S_CROP);
 
-       return video_register_device(vfd, VFL_TYPE_GRABBER, 0);
+       ret = video_register_device(vfd, VFL_TYPE_GRABBER, 0);
+       if (!ret)
+               v4l2_info(&dev->v4l2_dev, "%s registered as %s\n",
+                         type == CODA_INST_ENCODER ? "encoder" : "decoder",
+                         video_device_node_name(vfd));
+       return ret;
 }
 
 static void coda_copy_firmware(struct coda_dev *dev, const u8 * const buf,
@@ -2639,9 +2647,6 @@ static void coda_fw_callback(const struct firmware *fw, void *context)
                }
        }
 
-       v4l2_info(&dev->v4l2_dev, "codec registered as /dev/video[%d-%d]\n",
-                 dev->vfd[0].num, dev->vfd[i - 1].num);
-
        pm_runtime_put_sync(&pdev->dev);
        return;