souphttpsrc: Free extra headers when finalizing the element
authorSebastian Dröge <sebastian@centricular.com>
Thu, 13 Feb 2014 09:30:09 +0000 (10:30 +0100)
committerSebastian Dröge <sebastian@centricular.com>
Thu, 13 Feb 2014 09:36:29 +0000 (10:36 +0100)
It's set as property by the application, we should not just reset
properties when going back to READY.

ext/soup/gstsouphttpsrc.c

index 05ce0d3..9572a7b 100644 (file)
@@ -415,6 +415,11 @@ gst_soup_http_src_finalize (GObject * gobject)
   g_free (src->proxy_pw);
   g_strfreev (src->cookies);
 
+  if (src->extra_headers) {
+    gst_structure_free (src->extra_headers);
+    src->extra_headers = NULL;
+  }
+
   G_OBJECT_CLASS (parent_class)->finalize (gobject);
 }
 
@@ -1459,11 +1464,6 @@ gst_soup_http_src_stop (GstBaseSrc * bsrc)
   else
     gst_soup_http_src_session_close (src);
 
-  if (src->extra_headers) {
-    gst_structure_free (src->extra_headers);
-    src->extra_headers = NULL;
-  }
-
   gst_soup_http_src_reset (src);
   return TRUE;
 }