media: pci: cx88: Replace mdelay() with msleep() in cx88_card_setup_pre_i2c()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 Jul 2018 03:38:23 +0000 (23:38 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 27 Jul 2018 12:14:47 +0000 (08:14 -0400)
cx88_card_setup_pre_i2c() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/pci/cx88/cx88-cards.c

index 4c92d23..07e1483 100644 (file)
@@ -3307,9 +3307,9 @@ static void cx88_card_setup_pre_i2c(struct cx88_core *core)
        case CX88_BOARD_PROLINK_PV_GLOBAL_XTREME:
        case CX88_BOARD_PROLINK_PV_8000GT:
                cx_write(MO_GP2_IO, 0xcf7);
-               mdelay(50);
+               msleep(50);
                cx_write(MO_GP2_IO, 0xef5);
-               mdelay(50);
+               msleep(50);
                cx_write(MO_GP2_IO, 0xcf7);
                usleep_range(10000, 20000);
                break;