projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3caa693
)
fs: drop peer group ids under namespace lock
author
Christian Brauner
<brauner@kernel.org>
Thu, 30 Mar 2023 07:13:16 +0000
(09:13 +0200)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Thu, 13 Apr 2023 14:55:33 +0000
(16:55 +0200)
commit
cb2239c198ad9fbd5aced22cf93e45562da781eb
upstream.
When cleaning up peer group ids in the failure path we need to make sure
to hold on to the namespace lock. Otherwise another thread might just
turn the mount from a shared into a non-shared mount concurrently.
Link:
https://lore.kernel.org/lkml/00000000000088694505f8132d77@google.com
Fixes:
2a1867219c7b
("fs: add mount_setattr()")
Reported-by: syzbot+8ac3859139c685c4f597@syzkaller.appspotmail.com
Cc: stable@vger.kernel.org # 5.12+
Message-Id: <
20230330
-vfs-mount_setattr-propagation-fix-v1-1-
37548d91533b
@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/namespace.c
patch
|
blob
|
history
diff --git
a/fs/namespace.c
b/fs/namespace.c
index
df137ba
..
e04a9e9
100644
(file)
--- a/
fs/namespace.c
+++ b/
fs/namespace.c
@@
-4180,9
+4180,9
@@
out:
unlock_mount_hash();
if (kattr->propagation) {
- namespace_unlock();
if (err)
cleanup_group_ids(mnt, NULL);
+ namespace_unlock();
}
return err;