gpio: sim: check the label length when setting up device properties
authorBartosz Golaszewski <brgl@bgdev.pl>
Thu, 20 Jan 2022 19:49:48 +0000 (20:49 +0100)
committerBartosz Golaszewski <brgl@bgdev.pl>
Mon, 24 Jan 2022 08:20:02 +0000 (09:20 +0100)
If the user-space sets the chip label to an empty string - we should
check the length and not override the default name or else line hogs
will not be properly attached.

Fixes: cb8c474e79be ("gpio: sim: new testing module")
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpio-sim.c

index 838bbfe..04b137e 100644 (file)
@@ -816,7 +816,7 @@ gpio_sim_make_bank_swnode(struct gpio_sim_bank *bank,
 
        properties[prop_idx++] = PROPERTY_ENTRY_U32("ngpios", bank->num_lines);
 
-       if (bank->label)
+       if (bank->label && (strlen(bank->label) > 0))
                properties[prop_idx++] = PROPERTY_ENTRY_STRING("gpio-sim,label",
                                                               bank->label);