input: ist3xx: Fixes string buffer overflow 91/206091/3 accepted/tizen/unified/20190515.085003 submit/tizen/20190514.075217
authorJaechul Lee <jcsing.lee@samsung.com>
Tue, 14 May 2019 07:19:29 +0000 (16:19 +0900)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Tue, 14 May 2019 07:47:14 +0000 (07:47 +0000)
The string buffer has page size but sizeof returns 4.

Fixes: 81925d011289 ("input: ist3xx: replace misused strncat with s(n)printf")
Change-Id: Ia2272b385e510fd5a4df944ce19b3fe64220896a
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
drivers/input/touchscreen/imagis_30xxc/ist30xxc_sec.c

index 1ff3e40..445f9fa 100644 (file)
@@ -1763,7 +1763,7 @@ static ssize_t show_cmd_list(struct device *dev, struct device_attribute
 
        while(strncmp(tsp_cmds[ii].cmd_name, "not_support_cmd", 16) != 0) {
                snprintf(temp, COMMAND_LENGTH, "%s\n", tsp_cmds[ii].cmd_name);
-               strlcat(buffer, temp, sizeof(buffer));
+               strlcat(buffer, temp, FACTORY_BUF_SIZE);
                ii++;
        }