amc: Fix crash when encoding AVC
authorXavier Claessens <xavier.claessens@collabora.com>
Thu, 29 Oct 2020 17:43:16 +0000 (13:43 -0400)
committerGStreamer Merge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Thu, 29 Oct 2020 17:51:57 +0000 (17:51 +0000)
gstamcvideoenc.c calls gst_amc_avc_profile_to_string() with alternatives
set to NULL which causes a crash.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1732>

sys/androidmedia/gstamc.c

index 8276046..527446a 100644 (file)
@@ -1197,7 +1197,8 @@ gst_amc_avc_profile_to_string (gint profile, const gchar ** alternative)
 
   for (i = 0; i < G_N_ELEMENTS (avc_profile_mapping_table); i++) {
     if (avc_profile_mapping_table[i].id == profile) {
-      *alternative = avc_profile_mapping_table[i].alt_str;
+      if (alternative != NULL)
+        *alternative = avc_profile_mapping_table[i].alt_str;
       return avc_profile_mapping_table[i].str;
     }
   }