drm/msm: remove redundant NULL check
authorJiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Tue, 26 Jan 2021 09:51:19 +0000 (17:51 +0800)
committerRob Clark <robdclark@chromium.org>
Sun, 31 Jan 2021 19:34:36 +0000 (11:34 -0800)
Fix below warnings reported by coccicheck:
./drivers/gpu/drm/msm/msm_gem.c:991:3-9: WARNING: NULL check before some
freeing functions is not needed.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/msm_gem.c

index 9d10739..4f1f1a0 100644 (file)
@@ -987,8 +987,7 @@ void msm_gem_free_object(struct drm_gem_object *obj)
                /* Don't drop the pages for imported dmabuf, as they are not
                 * ours, just free the array we allocated:
                 */
-               if (msm_obj->pages)
-                       kvfree(msm_obj->pages);
+               kvfree(msm_obj->pages);
 
                put_iova_vmas(obj);