emotion: play set before file open callback bug fix
authorWonguk Jeong <wonguk.jeong@samsung.com>
Thu, 24 Apr 2014 09:10:10 +0000 (18:10 +0900)
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>
Thu, 24 Apr 2014 09:10:10 +0000 (18:10 +0900)
Summary:
Before "open_done" callback, play unset is ineffective.
is it intentional logic?

if we set play and unset play again before "open_done" callback, the video will be played.

@fix

Reviewers: raster, cedric

CC: seoz, cedric
Differential Revision: https://phab.enlightenment.org/D786

src/lib/emotion/emotion_smart.c

index 182560e..7ec603b 100644 (file)
@@ -661,13 +661,13 @@ emotion_object_play_set(Evas_Object *obj, Eina_Bool play)
 
    E_SMART_OBJ_GET(sd, obj, E_OBJ_NAME);
    DBG("play=" FMT_UCHAR ", was=" FMT_UCHAR, play, sd->play);
-   if (play == sd->play) return;
    if (!sd->engine_instance) return;
    if (!sd->open)
      {
         sd->remember_play = play;
         return;
      }
+   if (play == sd->play) return;
    sd->play = play;
    sd->remember_play = play;
    if (sd->state != EMOTION_WAKEUP) emotion_object_suspend_set(obj, EMOTION_WAKEUP);