x86: sound: Correct error handling

A few functions have changed to return pin numbers or I2C addresses. The
error checking for some of the callers is therefore wrong. Fix them.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

diff --git a/drivers/sound/da7219.c b/drivers/sound/da7219.c
index 6bc1ad0..8d674bc 100644 (file)
--- a/drivers/sound/da7219.c
+++ b/drivers/sound/da7219.c
@@ -54,13 +54,13 @@ static int da7219_acpi_fill_ssdt(const struct udevice *dev,
        acpigen_write_name(ctx, "_CRS");
        acpigen_write_resourcetemplate_header(ctx);
        ret = acpi_device_write_i2c_dev(ctx, dev);
-       if (ret)
+       if (ret < 0)
                return log_msg_ret("i2c", ret);
 
        /* Use either Interrupt() or GpioInt() */
        ret = acpi_device_write_interrupt_or_gpio(ctx, (struct udevice *)dev,
                                                  "req-gpios");
-       if (ret)
+       if (ret < 0)
                return log_msg_ret("irq_gpio", ret);
        acpigen_write_resourcetemplate_footer(ctx);
 

diff --git a/drivers/sound/max98357a.c b/drivers/sound/max98357a.c
index 827262d..b3d27a3 100644 (file)
--- a/drivers/sound/max98357a.c
+++ b/drivers/sound/max98357a.c
@@ -69,7 +69,7 @@ static int max98357a_acpi_fill_ssdt(const struct udevice *dev,
        acpigen_write_name(ctx, "_CRS");
        acpigen_write_resourcetemplate_header(ctx);
        ret = acpi_device_write_gpio_desc(ctx, &priv->sdmode_gpio);
-       if (ret)
+       if (ret < 0)
                return log_msg_ret("gpio", ret);
        acpigen_write_resourcetemplate_footer(ctx);