webrtc lib: Make the DTLSTransport struct private
authorOlivier CrĂȘte <olivier.crete@collabora.com>
Wed, 21 Apr 2021 20:19:41 +0000 (16:19 -0400)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Mon, 21 Jun 2021 20:53:09 +0000 (20:53 +0000)
This will prevent any unsafe access.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2241>

gst-libs/gst/webrtc/dtlstransport.c
gst-libs/gst/webrtc/dtlstransport.h
gst-libs/gst/webrtc/webrtc-priv.h

index bba2e35..e127555 100644 (file)
@@ -32,6 +32,8 @@
 
 #include "dtlstransport.h"
 
+#include "webrtc-priv.h"
+
 #define GST_CAT_DEFAULT gst_webrtc_dtls_transport_debug
 GST_DEBUG_CATEGORY_STATIC (GST_CAT_DEFAULT);
 
index 72a8ee9..0198619 100644 (file)
@@ -35,38 +35,6 @@ GType gst_webrtc_dtls_transport_get_type(void);
 #define GST_IS_WEBRTC_DTLS_TRANSPORT_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE((klass) ,GST_TYPE_WEBRTC_DTLS_TRANSPORT))
 #define GST_WEBRTC_DTLS_TRANSPORT_GET_CLASS(obj)  (G_TYPE_INSTANCE_GET_CLASS((obj) ,GST_TYPE_WEBRTC_DTLS_TRANSPORT,GstWebRTCDTLSTransportClass))
 
-/**
- * GstWebRTCDTLSTransport:
- */
-struct _GstWebRTCDTLSTransport
-{
-  GstObject                          parent;
-
-  GstWebRTCICETransport             *transport;
-  GstWebRTCDTLSTransportState        state;
-
-  gboolean                           client;
-  guint                              session_id;
-  GstElement                        *dtlssrtpenc;
-  GstElement                        *dtlssrtpdec;
-
-  gpointer                          _padding[GST_PADDING];
-};
-
-struct _GstWebRTCDTLSTransportClass
-{
-  GstObjectClass               parent_class;
-
-  gpointer                  _padding[GST_PADDING];
-};
-
-GST_WEBRTC_API
-GstWebRTCDTLSTransport *    gst_webrtc_dtls_transport_new               (guint session_id);
-
-GST_WEBRTC_API
-void                        gst_webrtc_dtls_transport_set_transport     (GstWebRTCDTLSTransport * transport,
-                                                                         GstWebRTCICETransport * ice);
-
 G_DEFINE_AUTOPTR_CLEANUP_FUNC(GstWebRTCDTLSTransport, gst_object_unref)
 
 G_END_DECLS
index 7a23827..3e9bf38 100644 (file)
@@ -199,6 +199,38 @@ void            gst_webrtc_ice_transport_selected_pair_change       (GstWebRTCIC
 GST_WEBRTC_API
 void            gst_webrtc_ice_transport_new_candidate              (GstWebRTCICETransport * ice, guint stream_id, GstWebRTCICEComponent component, gchar * attr);
 
+/**
+ * GstWebRTCDTLSTransport:
+ */
+struct _GstWebRTCDTLSTransport
+{
+  GstObject                          parent;
+
+  GstWebRTCICETransport             *transport;
+  GstWebRTCDTLSTransportState        state;
+
+  gboolean                           client;
+  guint                              session_id;
+  GstElement                        *dtlssrtpenc;
+  GstElement                        *dtlssrtpdec;
+
+  gpointer                          _padding[GST_PADDING];
+};
+
+struct _GstWebRTCDTLSTransportClass
+{
+  GstObjectClass               parent_class;
+
+  gpointer                  _padding[GST_PADDING];
+};
+
+GST_WEBRTC_API
+GstWebRTCDTLSTransport *    gst_webrtc_dtls_transport_new               (guint session_id);
+
+GST_WEBRTC_API
+void                        gst_webrtc_dtls_transport_set_transport     (GstWebRTCDTLSTransport * transport,
+                                                                         GstWebRTCICETransport * ice);
+
 
 G_END_DECLS