cxl/mem: Skip range enumeration if mem_enable clear
authorDan Williams <dan.j.williams@intel.com>
Wed, 18 May 2022 23:34:54 +0000 (16:34 -0700)
committerDan Williams <dan.j.williams@intel.com>
Thu, 19 May 2022 15:50:41 +0000 (08:50 -0700)
When a device does not have mem_enable set then the current range
settings are moot. Skip the enumeration and cause cxl_hdm_decode_init()
to proceed directly to enable the HDM Decoder Capability.

Fixes: 560f78559006 ("cxl/pci: Retrieve CXL DVSEC memory info")
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/165291689442.1426646.18012291761753694336.stgit@dwillia2-xfh
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/cxl/core/pci.c
drivers/cxl/mem.c

index ea67117..f3e59f8 100644 (file)
@@ -224,6 +224,8 @@ int cxl_dvsec_ranges(struct cxl_dev_state *cxlds,
        }
 
        info->mem_enabled = FIELD_GET(CXL_DVSEC_MEM_ENABLE, ctrl);
+       if (!info->mem_enabled)
+               return 0;
 
        for (i = 0; i < hdm_count; i++) {
                u64 base, size;
index 0cfbde1..902d1f6 100644 (file)
@@ -92,7 +92,7 @@ __mock bool cxl_hdm_decode_init(struct cxl_dev_state *cxlds,
         * are expected even though Linux does not require or maintain that
         * match.
         */
-       if (!global_enable && info->ranges)
+       if (!global_enable && info->mem_enabled && info->ranges)
                goto out;
 
        retval = true;