ASoC: topology: Set correct unload callback for graph type
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Wed, 1 Feb 2023 11:28:46 +0000 (13:28 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 2 Feb 2023 11:09:53 +0000 (11:09 +0000)
Using the control_unload for graph type of elem will lead surprises on
module unload.

The correct callback to use is the dapm_route_unload.

Fixes: 31e9273912bf ("ASoC: topology: Use unload() op directly")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/20230201112846.27707-3-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-topology.c

index caf5478..7822360 100644 (file)
@@ -1081,7 +1081,7 @@ static int soc_tplg_dapm_graph_elems_load(struct soc_tplg *tplg,
                /* add route dobj to dobj_list */
                route->dobj.type = SND_SOC_DOBJ_GRAPH;
                if (tplg->ops)
-                       route->dobj.unload = tplg->ops->control_unload;
+                       route->dobj.unload = tplg->ops->dapm_route_unload;
                route->dobj.index = tplg->index;
                list_add(&route->dobj.list, &tplg->comp->dobj_list);