fix the bug of ocl::bruteForceMatcher
authoryao <bitwangyaoyao@gmail.com>
Fri, 25 Oct 2013 08:01:41 +0000 (16:01 +0800)
committeryao <bitwangyaoyao@gmail.com>
Fri, 25 Oct 2013 08:01:41 +0000 (16:01 +0800)
modules/ocl/perf/perf_brute_force_matcher.cpp
modules/ocl/src/opencl/brute_force_match.cl

index 33c42c7..09b99f5 100644 (file)
@@ -53,8 +53,8 @@ using namespace perf;
 
 typedef TestBaseWithParam<Size> BruteForceMatcherFixture;
 
-PERF_TEST_P(BruteForceMatcherFixture, DISABLED_match,
-            OCL_BFMATCHER_TYPICAL_MAT_SIZES) // TODO too big difference between implementations
+PERF_TEST_P(BruteForceMatcherFixture, match,
+            OCL_BFMATCHER_TYPICAL_MAT_SIZES)
 {
     const Size srcSize = GetParam();
 
@@ -82,14 +82,14 @@ PERF_TEST_P(BruteForceMatcherFixture, DISABLED_match,
 
         oclMatcher.matchDownload(oclTrainIdx, oclDistance, matches);
 
-        SANITY_CHECK_MATCHES(matches);
+        SANITY_CHECK_MATCHES(matches, 1e-5);
     }
     else
         OCL_PERF_ELSE
 }
 
-PERF_TEST_P(BruteForceMatcherFixture, DISABLED_knnMatch,
-            OCL_BFMATCHER_TYPICAL_MAT_SIZES) // TODO too big difference between implementations
+PERF_TEST_P(BruteForceMatcherFixture, knnMatch,
+            OCL_BFMATCHER_TYPICAL_MAT_SIZES)
 {
     const Size srcSize = GetParam();
 
@@ -123,8 +123,8 @@ PERF_TEST_P(BruteForceMatcherFixture, DISABLED_knnMatch,
         oclMatcher.knnMatchDownload(oclTrainIdx, oclDistance, matches);
 
         std::vector<DMatch> & matches0 = matches[0], & matches1 = matches[1];
-        SANITY_CHECK_MATCHES(matches0);
-        SANITY_CHECK_MATCHES(matches1);
+        SANITY_CHECK_MATCHES(matches0, 1e-5);
+        SANITY_CHECK_MATCHES(matches1, 1e-5);
     }
     else
         OCL_PERF_ELSE
index a05c98e..ad668e6 100644 (file)
@@ -17,6 +17,7 @@
 // @Authors
 //    Nathan, liujun@multicorewareinc.com
 //    Peng Xiao, pengxiao@outlook.com
+//    Baichuan Su, baichuan@multicorewareinc.com
 //
 // Redistribution and use in source and binary forms, with or without modification,
 // are permitted provided that the following conditions are met:
@@ -128,7 +129,7 @@ result_type reduce_multi_block(
             s_query[lidy * MAX_DESC_LEN + block_index * BLOCK_SIZE + j],
             s_train[j * BLOCK_SIZE + lidx]);
     }
-    return DIST_RES(result);
+    return result;
 }
 
 /* 2dim launch, global size: dim0 is (query rows + BLOCK_SIZE - 1) / BLOCK_SIZE * BLOCK_SIZE, dim1 is BLOCK_SIZE
@@ -187,6 +188,8 @@ __kernel void BruteForceMatch_UnrollMatch(
             barrier(CLK_LOCAL_MEM_FENCE);
         }
 
+        result = DIST_RES(result);
+
         int trainIdx = t * BLOCK_SIZE + lidx;
 
         if (queryIdx < query_rows && trainIdx < train_rows && result < myBestDistance/* && mask(queryIdx, trainIdx)*/)
@@ -493,6 +496,8 @@ __kernel void BruteForceMatch_knnUnrollMatch(
             barrier(CLK_LOCAL_MEM_FENCE);
         }
 
+        result = DIST_RES(result);
+
         const int trainIdx = t * BLOCK_SIZE + lidx;
 
         if (queryIdx < query_rows && trainIdx < train_rows)