[flang] Remove unnecessary defaults in switches.
authorTim Keith <tkeith@nvidia.com>
Wed, 25 Apr 2018 18:44:12 +0000 (11:44 -0700)
committerTim Keith <tkeith@nvidia.com>
Wed, 25 Apr 2018 18:44:12 +0000 (11:44 -0700)
Original-commit: flang-compiler/f18@f4835e3831f875fb3ae56f390201ab34422c64e3
Reviewed-on: https://github.com/flang-compiler/f18/pull/70
Tree-same-pre-rewrite: false

flang/lib/semantics/resolve-names.cc

index 70a9926..6f7d787 100644 (file)
@@ -95,8 +95,9 @@ protected:
     switch (x.v) {
     case parser::AccessSpec::Kind::Public: return Attr::PUBLIC;
     case parser::AccessSpec::Kind::Private: return Attr::PRIVATE;
-    default: CRASH_NO_CASE;
     }
+    // unnecessary but g++ warns "control reaches end of non-void function"
+    parser::die("unreachable");
   }
 };
 
@@ -540,7 +541,6 @@ bool AttrsVisitor::Pre(const parser::IntentSpec &x) {
     attrs_->set(Attr::INTENT_IN);
     attrs_->set(Attr::INTENT_OUT);
     break;
-  default: CRASH_NO_CASE;
   }
   return false;
 }
@@ -775,7 +775,6 @@ bool ImplicitRulesVisitor::HandleImplicitNone(
         }
         ++sawType;
         break;
-      default: CRASH_NO_CASE;
       }
     }
     if (sawType > 1) {