projects
/
platform
/
core
/
api
/
inputmethod.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1ec4976
)
Fix logical error code
86/240786/1
author
Jihoon Kim
<jihoon48.kim@samsung.com>
Tue, 11 Aug 2020 10:38:10 +0000
(19:38 +0900)
committer
Jihoon Kim
<jihoon48.kim@samsung.com>
Tue, 11 Aug 2020 10:38:12 +0000
(19:38 +0900)
Expression 'portrait_line < 0' is always false , which may be caused by a logical error
Change-Id: I0ee7ccbf96a0c66c25d11b221dab1bebf297f2c7
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
inputmethod/src/inputmethod.cpp
patch
|
blob
|
history
diff --git
a/inputmethod/src/inputmethod.cpp
b/inputmethod/src/inputmethod.cpp
index
4706d71
..
b2b9e8f
100644
(file)
--- a/
inputmethod/src/inputmethod.cpp
+++ b/
inputmethod/src/inputmethod.cpp
@@
-2885,11
+2885,6
@@
EXPORT_API int ime_set_candidate_style(scim::ISF_CANDIDATE_PORTRAIT_LINE_T portr
{
ime_error_e retVal = IME_ERROR_NONE;
- if (portrait_line < 0 || mode < 0) {
- LOGW("IME_ERROR_INVALID_PARAMETER");
- return IME_ERROR_INVALID_PARAMETER;
- }
-
if (!g_running) {
LOGW("IME_ERROR_NOT_RUNNING");
return IME_ERROR_NOT_RUNNING;