Fix YCbCr linear filtering support check
authorGraeme Leese <gleese@broadcom.com>
Thu, 10 Jun 2021 12:57:42 +0000 (13:57 +0100)
committerAlexander Galazin <Alexander.Galazin@arm.com>
Tue, 29 Jun 2021 07:11:21 +0000 (07:11 +0000)
The code was incorrectly checking the CONVERSION_LINEAR bit, which
determines whether a chromaFilter of linear is allowed, instead of the
more generic FILTER_LINEAR bit.

See vulkan/vulkan!4623

Component: Vulkan
Affects: dEQP-VK.ycbcr.*

Change-Id: Ifcacde146c10c24401e9efcc6095f5d0c5c8c519

external/vulkancts/modules/vulkan/ycbcr/vktYCbCrConversionTests.cpp

index adc7d87..b5e4813 100644 (file)
@@ -622,8 +622,8 @@ void checkSupport (Context& context, const TestConfig config)
                if ((features & vk::VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT) == 0)
                        TCU_THROW(NotSupportedError, "Format doesn't support sampling");
 
-               if (config.textureFilter == vk::VK_FILTER_LINEAR && ((features & vk::VK_FORMAT_FEATURE_SAMPLED_IMAGE_YCBCR_CONVERSION_LINEAR_FILTER_BIT) == 0))
-                       TCU_THROW(NotSupportedError, "Format doesn't support YCbCr linear chroma reconstruction");
+               if (config.textureFilter == vk::VK_FILTER_LINEAR && ((features & vk::VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT) == 0))
+                       TCU_THROW(NotSupportedError, "Format doesn't support linear texture filtering");
 
                if (config.chromaFilter == vk::VK_FILTER_LINEAR && ((features & vk::VK_FORMAT_FEATURE_SAMPLED_IMAGE_YCBCR_CONVERSION_LINEAR_FILTER_BIT) == 0))
                        TCU_THROW(NotSupportedError, "Format doesn't support YCbCr linear chroma reconstruction");