selftests: mptcp: clean tmp files in simult_flows
authorMatthieu Baerts <matthieu.baerts@tessares.net>
Wed, 1 Sep 2021 17:15:37 +0000 (10:15 -0700)
committerDom Cobley <popcornmix@gmail.com>
Thu, 14 Oct 2021 11:32:59 +0000 (12:32 +0100)
[ Upstream commit bfd862a7e9318dd906844807a713d27cdd1a72b1 ]

'$cin' and '$sin' variables are local to a function: they are then not
available from the cleanup trap.

Instead, we need to use '$large' and '$small' that are not local and
defined just before setting the trap.

Without this patch, running this script in a loop might cause a:

  write: No space left on device

issue.

Fixes: 1a418cb8e888 ("mptcp: simult flow self-tests")
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/net/mptcp/simult_flows.sh

index 2f649b4..8fcb289 100755 (executable)
@@ -21,8 +21,8 @@ usage() {
 
 cleanup()
 {
-       rm -f "$cin" "$cout"
-       rm -f "$sin" "$sout"
+       rm -f "$cout" "$sout"
+       rm -f "$large" "$small"
        rm -f "$capout"
 
        local netns