firmware: Remove the sanity checks in fw_save_info()
authorBin Meng <bmeng.cn@gmail.com>
Wed, 7 Jul 2021 10:00:21 +0000 (18:00 +0800)
committerAnup Patel <anup@brainfault.org>
Sun, 11 Jul 2021 08:39:10 +0000 (14:09 +0530)
The sanity checks on the magic and version was already done in
fw_boot_hart(), which happens before fw_save_info() is called.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Xiang W <wxjstz@126.com>
Reviewed-by: Anup Patel <anup.patel@wdc.com>
firmware/fw_dynamic.S

index 0705e63..945fa04 100644 (file)
@@ -57,14 +57,6 @@ fw_save_info:
        lla     a4, _dynamic_next_arg1
        REG_S   a1, (a4)
 
-       /* Sanity checks */
-       li      a4, FW_DYNAMIC_INFO_MAGIC_VALUE
-       REG_L   a3, FW_DYNAMIC_INFO_MAGIC_OFFSET(a2)
-       bne     a3, a4, _bad_dynamic_info
-       li      a4, FW_DYNAMIC_INFO_VERSION_MAX
-       REG_L   a3, FW_DYNAMIC_INFO_VERSION_OFFSET(a2)
-       bgt     a3, a4, _bad_dynamic_info
-
        /* Save version == 0x1 fields */
        lla     a4, _dynamic_next_addr
        REG_L   a3, FW_DYNAMIC_INFO_NEXT_ADDR_OFFSET(a2)