Some cosmetic issues.
authorantonm@chromium.org <antonm@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Fri, 12 Mar 2010 18:27:31 +0000 (18:27 +0000)
committerantonm@chromium.org <antonm@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Fri, 12 Mar 2010 18:27:31 +0000 (18:27 +0000)
Review URL: http://codereview.chromium.org/903004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4122 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

src/array.js
src/ia32/stub-cache-ia32.cc

index e2aa4ad116724922d55dc7b9ffa129b967f23596..95d4ada1646e41d415b43e468717638af1119124 100644 (file)
@@ -1107,7 +1107,7 @@ function SetupArray() {
     if (specialFunctions.hasOwnProperty(name)) {
       f = specialFunctions[name];
     }
-    if (arguments.length == 3) {
+    if (!IS_UNDEFINED(len)) {
       %FunctionSetLength(f, len);
     }
     return f;
index 3c50f0d60449e6431363a4cee7c2ebf10459747e..902a5b81065a0ecfef42f537c49b9b951f110475 100644 (file)
@@ -1247,7 +1247,7 @@ Object* CallStubCompiler::CompileArrayPushCall(Object* object,
 
     // Check that the elements are in fast mode (not dictionary).
     __ cmp(FieldOperand(ebx, HeapObject::kMapOffset),
-            Immediate(Factory::fixed_array_map()));
+           Immediate(Factory::fixed_array_map()));
     __ j(not_equal, &miss);
 
     if (argc == 1) {  // Otherwise fall through to call builtin.
@@ -1277,7 +1277,7 @@ Object* CallStubCompiler::CompileArrayPushCall(Object* object,
       __ mov(ecx, Operand(esp, argc * kPointerSize));
       __ mov(Operand(edx, 0), ecx);
 
-      // Check if wrote not a smi.
+      // Check if value is a smi.
       __ test(ecx, Immediate(kSmiTagMask));
       __ j(not_zero, &with_rset_update);