media: coda/imx-vdoa: Remove irq member from vdoa_data struct
authorFabio Estevam <fabio.estevam@nxp.com>
Tue, 19 Dec 2017 00:58:44 +0000 (19:58 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 19 Dec 2017 13:09:10 +0000 (08:09 -0500)
The 'irq' member of the vdoa_data struct is only used inside probe,
so there is no need for it. Use a local variable 'ret' instead.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/coda/imx-vdoa.c

index 8eb3e0c..85a66e4 100644 (file)
@@ -86,7 +86,6 @@ struct vdoa_data {
        struct device           *dev;
        struct clk              *vdoa_clk;
        void __iomem            *regs;
-       int                     irq;
 };
 
 struct vdoa_q_data {
@@ -293,6 +292,7 @@ static int vdoa_probe(struct platform_device *pdev)
 {
        struct vdoa_data *vdoa;
        struct resource *res;
+       int ret;
 
        dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
 
@@ -316,12 +316,12 @@ static int vdoa_probe(struct platform_device *pdev)
        res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
        if (!res)
                return -EINVAL;
-       vdoa->irq = devm_request_threaded_irq(&pdev->dev, res->start, NULL,
+       ret = devm_request_threaded_irq(&pdev->dev, res->start, NULL,
                                        vdoa_irq_handler, IRQF_ONESHOT,
                                        "vdoa", vdoa);
-       if (vdoa->irq < 0) {
+       if (ret < 0) {
                dev_err(vdoa->dev, "Failed to get irq\n");
-               return vdoa->irq;
+               return ret;
        }
 
        platform_set_drvdata(pdev, vdoa);