Fix parameter order

- Change parameter order width and height.
- add gst_object_unref of srcbin in case of error.

Signed-off-by: SeokHoon Lee <andy.shlee@samsung.com>
Change-Id: I9a328d2c9da4b83074c569ddd6f8bc628c845fbd

diff --git a/gst/rtsp-server/rtsp-client-wfd.c b/gst/rtsp-server/rtsp-client-wfd.c
index 672e121..4bacef6 100644 (file)
--- a/gst/rtsp-server/rtsp-client-wfd.c
+++ b/gst/rtsp-server/rtsp-client-wfd.c
@@ -2387,7 +2387,7 @@ _set_wfd_message_body (GstRTSPWFDClient * client, GstWFDMessageType msg_type,
         gst_wfd_message_set_preferred_video_format (msg, priv->cvCodec,
         priv->video_native_resolution, GST_WFD_CEA_UNKNOWN, tcCEAResolution,
         tcVESAResolution, tcHHResolution, tcProfile, tcLevel, priv->cvLatency,
-        priv->cMaxWidth, priv->cMaxHeight, priv->cmin_slice_size,
+        priv->cMaxHeight, priv->cMaxWidth, priv->cmin_slice_size,
         priv->cslice_enc_params, priv->cframe_rate_control);
 
     if (wfd_res != GST_WFD_OK) {
@@ -2400,7 +2400,7 @@ _set_wfd_message_body (GstRTSPWFDClient * client, GstWFDMessageType msg_type,
         gst_wfd_message_set_preferred_direct_video_format (msg, priv->cvCodec,
             priv->video_native_resolution, GST_WFD_CEA_UNKNOWN, tcCEAResolution,
             tcVESAResolution, tcHHResolution, tcProfile, tcLevel, priv->cvLatency,
-            priv->cMaxWidth, priv->cMaxHeight, priv->cmin_slice_size,
+            priv->cMaxHeight, priv->cMaxWidth, priv->cmin_slice_size,
             priv->cslice_enc_params, priv->cframe_rate_control);
 
       if (wfd_res != GST_WFD_OK) {

diff --git a/gst/rtsp-server/rtsp-media-factory-wfd.c b/gst/rtsp-server/rtsp-media-factory-wfd.c
index fd6373c..3c31546 100644 (file)
--- a/gst/rtsp-server/rtsp-media-factory-wfd.c
+++ b/gst/rtsp-server/rtsp-media-factory-wfd.c
@@ -1415,6 +1415,8 @@ create_error:
     gst_object_unref (mux_asinkpad);
   if (srcpad)
     gst_object_unref (srcpad);
+  if (srcbin)
+    gst_object_unref (srcbin);
   return NULL;
 }