video: vt8500lcdfb: fix fallthrough warning
authorSam Ravnborg <sam@ravnborg.org>
Sun, 12 Apr 2020 20:21:43 +0000 (22:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Jun 2020 14:40:33 +0000 (16:40 +0200)
commit 1c49f35e9e9156273124a0cfd38b57f7a7d4828f upstream.

Fix following warning:
vt8500lcdfb.c: In function 'vt8500lcd_blank':
vt8500lcdfb.c:229:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
      if (info->fix.visual == FB_VISUAL_PSEUDOCOLOR ||
         ^
vt8500lcdfb.c:233:2: note: here
     case FB_BLANK_UNBLANK:
     ^~~~

Adding a simple "fallthrough;" fixed the warning.
The fix was build tested.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Reported-by: kbuild test robot <lkp@intel.com>
Fixes: e41f1a989408 ("fbdev: Implement simple blanking in pseudocolor modes for vt8500lcdfb")
Cc: Alexey Charkov <alchark@gmail.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: <stable@vger.kernel.org> # v2.6.38+
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200412202143.GA26948@ravnborg.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/video/fbdev/vt8500lcdfb.c

index be8d970..4b84fd4 100644 (file)
@@ -230,6 +230,7 @@ static int vt8500lcd_blank(int blank, struct fb_info *info)
                    info->fix.visual == FB_VISUAL_STATIC_PSEUDOCOLOR)
                        for (i = 0; i < 256; i++)
                                vt8500lcd_setcolreg(i, 0, 0, 0, 0, info);
+               fallthrough;
        case FB_BLANK_UNBLANK:
                if (info->fix.visual == FB_VISUAL_PSEUDOCOLOR ||
                    info->fix.visual == FB_VISUAL_STATIC_PSEUDOCOLOR)