ecore con - clean up file lock andunlock on failed bind
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>
Sun, 12 Apr 2020 17:30:36 +0000 (18:30 +0100)
committerJongmin Lee <jm105.lee@samsung.com>
Sun, 12 Apr 2020 21:17:44 +0000 (06:17 +0900)
didnt do this if bind failed... so do it now.

src/lib/ecore_con/efl_net_server_unix.c

index 3efe5fc..e731ebf 100644 (file)
@@ -111,20 +111,19 @@ _efl_net_server_unix_efl_object_destructor(Eo *o, Efl_Net_Server_Unix_Data *pd E
    if (fd != INVALID_SOCKET)
      {
         const char *address = efl_net_server_address_get(o);
-        if ((address) && (strncmp(address, "abstract:", strlen("abstract:")) != 0))
-          {
-             unlink(address);
+        if ((address) &&
+            (strncmp(address, "abstract:", strlen("abstract:")) != 0))
+          unlink(address);
+     }
 #ifdef BIND_HANG_WORKAROUND
-             if ((pd->have_lock_fd) && (pd->lock_fd >= 0))
-               {
-                  _efl_net_server_unix_bind_hang_lock_workaround
-                    (address, EINA_FALSE, pd->lock_fd);
-                  pd->lock_fd = -1;
-                  pd->have_lock_fd = EINA_FALSE;
-               }
-#endif
-          }
+   if ((pd->have_lock_fd) && (pd->lock_fd >= 0))
+     {
+        _efl_net_server_unix_bind_hang_lock_workaround
+          (address, EINA_FALSE, pd->lock_fd);
+        pd->lock_fd = -1;
+        pd->have_lock_fd = EINA_FALSE;
      }
+#endif
 
    efl_destructor(efl_super(o, MY_CLASS));
 }
@@ -274,6 +273,14 @@ _efl_net_server_unix_bind(Eo *o, Efl_Net_Server_Unix_Data *pd)
  error:
    if (err)
      {
+#ifdef BIND_HANG_WORKAROUND
+        if ((pd->have_lock_fd) && (pd->lock_fd >= 0))
+          {
+             pd->lock_fd = _efl_net_server_unix_bind_hang_lock_workaround
+               (addr.sun_path, EINA_FALSE, -1);
+             pd->have_lock_fd = EINA_TRUE;
+          }
+#endif
         efl_event_callback_call(o, EFL_NET_SERVER_EVENT_SERVER_ERROR, &err);
         if (fd != INVALID_SOCKET) closesocket(fd);
         efl_loop_fd_set(o, SOCKET_TO_LOOP_FD(INVALID_SOCKET));