Remove compile warning messages

Change-Id: I94eca9e33a0776784ae0cae1a52c5781eff84ce1
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>

diff --git a/src/launchpad_common.c b/src/launchpad_common.c
index 39a1a589977a41eba30c48d02250e2e665e58b8a..26fce8b63a0b100d91d3efb6688fe891c9943b0a 100644 (file)
--- a/src/launchpad_common.c
+++ b/src/launchpad_common.c
@@ -1383,7 +1383,7 @@ static int __send_raw(int fd, int cmd, unsigned char *data, int datalen)
 
 int _send_message_to_logger(const char *tag, const char *format, ...)
 {
-       char fmt[PATH_MAX];
+       char fmt[PATH_MAX - 256];
        char buf[PATH_MAX];
        va_list ap;
        int ret;

diff --git a/src/launchpad_hydra.c b/src/launchpad_hydra.c
index 5d43b5db6bb842dfa90dc778457f5305f92e96ae..7ffb5bdb54f747d1c144c82e64c80838179bd08a 100644 (file)
--- a/src/launchpad_hydra.c
+++ b/src/launchpad_hydra.c
@@ -258,6 +258,11 @@ static int __create_client_socket(const char *path)
        int retry = CONNECT_RETRY_COUNT;
        int fd;
 
+       if (sizeof(addr.sun_path) <= strlen(path)) {
+               _E("lenght of path is too long");
+               return -1;
+       }
+
        fd = socket(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0);
        if (fd < 0) {
                _E("Failed to create socket(%s). errno(%d)", path, errno);
@@ -265,7 +270,7 @@ static int __create_client_socket(const char *path)
        }
 
        addr.sun_family = AF_UNIX;
-       snprintf(addr.sun_path, sizeof(addr.sun_path), "%s", path);
+       strncpy(addr.sun_path, path, sizeof(addr.sun_path) - strlen(path) - 1);
        while (connect(fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
                if (errno != ETIMEDOUT || retry <= 0) {
                        _E("Failed to connect socket(%s). errno(%d)",

diff --git a/src/launchpad_signal.c b/src/launchpad_signal.c
index e6a650393edc25168069849b53a8989510bc86fc..8dbf5658647b6735853d1c20a2eb5a5e07176840 100644 (file)
--- a/src/launchpad_signal.c
+++ b/src/launchpad_signal.c
@@ -128,7 +128,7 @@ static void __socket_garbage_collector(void)
 {
        DIR *dp;
        struct dirent *dentry = NULL;
-       char tmp[MAX_LOCAL_BUFSZ];
+       char tmp[PATH_MAX];
 
        snprintf(tmp, sizeof(tmp), "/run/aul/apps/%d", getuid());
        dp = opendir(tmp);
@@ -139,7 +139,7 @@ static void __socket_garbage_collector(void)
                if (!isdigit(dentry->d_name[0]))
                        continue;
 
-               snprintf(tmp, MAX_LOCAL_BUFSZ, "/proc/%s", dentry->d_name);
+               snprintf(tmp, sizeof(tmp), "/proc/%s", dentry->d_name);
                if (access(tmp, F_OK) < 0) {    /* Flawfinder: ignore */
                        _delete_sock_path(atoi(dentry->d_name), getuid());
                        continue;