Tizen Coding Rule applied on /setting-appmgr folder

Change-Id: I7f9260980d317ee11eac624a528c82b6d0886ffc
Signed-off-by: Bartlomiej Uliasz <b.uliasz@samsung.com>

diff --git a/setting-appmgr/include/setting-appmgr.h b/setting-appmgr/include/setting-appmgr.h
index 7d8e961207b8d90cdbdff010defd575c724de713..82fbb1c64d8006f85a9b9d0a648737ab2f541926 100644 (file)
--- a/setting-appmgr/include/setting-appmgr.h
+++ b/setting-appmgr/include/setting-appmgr.h
@@ -32,13 +32,13 @@
 
 #define _S(s)  dgettext("sys_string", s)
 
-#define SAFE_STRDUP(src) (src)?strdup(src):NULL
+#define SAFE_STRDUP(src) (src) ? strdup(src) : NULL
 
 #define FREEandSTRDUP(dest, src) \
-       do{ \
-               if (dest) { free(dest); dest=NULL; }\
+       do { \
+               if (dest) { free(dest); dest = NULL; } \
                if (src || *src) dest = strdup(src); \
-       }while(false)
+       } while (false)
 
 enum {
        APPMGRUG_TAB_NONE,
@@ -206,7 +206,7 @@ typedef struct _SettingAppMgrUG {
                gettimeofday(&tv, NULL); \
                double now = tv.tv_sec * 1000 + (double)tv.tv_usec/1000; \
                SETTING_TRACE_DEBUG(fmt" time = %f ms", ##arg, now); \
-       }while(0)
+       } while (0)
 
 
 extern setting_view setting_view_appmgr_pkginfo;

diff --git a/setting-appmgr/src/setting-appmgr-async-worker.c b/setting-appmgr/src/setting-appmgr-async-worker.c
index e9bd1de009d9efa75ea0579b40ddc1ed6e776d86..d5fc7a5efb2258ac7da3152c095c3c41b08f0c74 100644 (file)
--- a/setting-appmgr/src/setting-appmgr-async-worker.c
+++ b/setting-appmgr/src/setting-appmgr-async-worker.c
@@ -55,9 +55,9 @@ static Eina_Bool _async_worker_idler(void *data)
        appmgrUg_worker *worker = data;
 
        retv_if(NULL == data, ECORE_CALLBACK_CANCEL);
-       if (worker && worker->tid) {
+       if (worker && worker->tid)
                pthread_join(worker->tid, NULL);
-       }
+
        worker->alive = FALSE;
 
        if (worker->cb)

diff --git a/setting-appmgr/src/setting-appmgr-main.c b/setting-appmgr/src/setting-appmgr-main.c
index 4e6ca6f622475bb6c7cb2ef34d129d8d44d6045c..75ee22fc199aa48529ce6918906a26e49641860c 100644 (file)
--- a/setting-appmgr/src/setting-appmgr-main.c
+++ b/setting-appmgr/src/setting-appmgr-main.c
@@ -106,13 +106,12 @@ static void appmgrUg_main_sort_popup(void *data, Evas_Object *obj,
                        MGRAPP_STR_SIZE,
                        NULL);
        SETTING_TRACE("ad->sort_str:%s", ad->sort_str);
-       if (!safeStrCmp(ad->sort_str, MGRAPP_STR_SIZE)) {
+       if (!safeStrCmp(ad->sort_str, MGRAPP_STR_SIZE))
                elm_radio_value_set(rdg, 2);
-       } else if (!safeStrCmp(ad->sort_str, MGRAPP_STR_Z_TO_A)) {
+       else if (!safeStrCmp(ad->sort_str, MGRAPP_STR_Z_TO_A))
                elm_radio_value_set(rdg, 1);
-       } else {
+       else
                elm_radio_value_set(rdg, 0);
-       }
 }
 
 static void appmgrUg_main_more_popup_rotate(void *data, Evas_Object *obj,
@@ -291,11 +290,10 @@ static inline Evas_Object *appmgrUg_main_no_item_handle(SettingAppMgrUG *ad)
        }
 
        if (NULL == ad->lo_noitem || ad->noitem_type != ad->tabtype) {
-               if (ad->tabtype == APPMGRUG_TAB_RUNNING) {
+               if (ad->tabtype == APPMGRUG_TAB_RUNNING)
                        lo = appmgrUg_loading_item(ad->navi, text, help_txt);
-               } else {
+               else
                        lo = appmgrUg_no_item(ad->navi, text, help_txt);
-               }
        }
 
        return lo;
@@ -317,9 +315,9 @@ void appmgrUg_main_genlist_append_items(SettingAppMgrUG *ad)
                return;
        }
 
-       if (NULL == ad->gl_main) {
+       if (NULL == ad->gl_main)
                lo_new = ad->gl_main = appmgrUg_main_genlist(ad->navi);
-       } else
+       else
                elm_genlist_clear(ad->gl_main);
 
        cursor = ad->pkg_list;

diff --git a/setting-appmgr/src/setting-appmgr-pkginfo-utils.c b/setting-appmgr/src/setting-appmgr-pkginfo-utils.c
index 763cbe91766fd3fc73929cf0cb9358404fad91ed..a095ac1fb55ab1502af734912ba2756a4b58a591 100644 (file)
--- a/setting-appmgr/src/setting-appmgr-pkginfo-utils.c
+++ b/setting-appmgr/src/setting-appmgr-pkginfo-utils.c
@@ -322,9 +322,8 @@ void appmgrUg_pkg_update_cache_size(void *data)
                                "elm.text.sub", ELM_GENLIST_ITEM_FIELD_TEXT);
        }
 
-       if (ad->clear_cache && ad->clear_cache->item) {
+       if (ad->clear_cache && ad->clear_cache->item)
                elm_genlist_item_update(ad->clear_cache->item);
-       }
 }
 
 static UNUSED int _appmgrUg_pkg_get_pkg_size(int req_id, const char *pkg_type,
@@ -414,9 +413,8 @@ static Eina_Bool __get_pkg_size_on_time(void *data)
        } else {
                int ret = package_manager_get_package_size_info(info->pkgid,
                                _get_cache_cb, ad);
-               if (ret != 0) {
+               if (ret != 0)
                        SETTING_TRACE_ERROR("failed to invoke ret = %d", ret);
-               }
        }
 
        /*get pkg total & data size */

diff --git a/setting-appmgr/src/setting-appmgr-pkginfo.c b/setting-appmgr/src/setting-appmgr-pkginfo.c
index 8669113096bbed4164c3c695c231e8e40d1d3dea..ab3d9cb933a1dc0de71382f14afde372fb98719a 100644 (file)
--- a/setting-appmgr/src/setting-appmgr-pkginfo.c
+++ b/setting-appmgr/src/setting-appmgr-pkginfo.c
@@ -207,10 +207,8 @@ static inline void appmgrUg_pkg_append_default(SettingAppMgrUG *ad)
 
        setting_create_Gendial_field_titleItem(ad->gl_pkg, &ad->itc_multiline,
                        MGRAPP_STR_DEFAULT_DESC, NULL);
-       if(1 != ret)
-       {
+       if (1 != ret)
                elm_object_item_disabled_set(data->item, EINA_TRUE);
-       }
 }
 
 static inline void appmgrUg_pkg_append_website(SettingAppMgrUG *ad)

diff --git a/setting-appmgr/src/setting-appmgr-runinfo.c b/setting-appmgr/src/setting-appmgr-runinfo.c
index aec14a7b558f4515c232b378f993956003354645..bf6d0caee5843f9fe7c44d08c436230c27ad03e8 100644 (file)
--- a/setting-appmgr/src/setting-appmgr-runinfo.c
+++ b/setting-appmgr/src/setting-appmgr-runinfo.c
@@ -181,11 +181,10 @@ void appmgrUg_run_stop_click(void *data, Evas_Object *obj, void *event_info)
                ad->info_run->runinfos = NULL;
                ad->info_run = NULL;
        }
-       if (APPMGRUG_TAB_RUNNING == ad->tabtype) {
+       if (APPMGRUG_TAB_RUNNING == ad->tabtype)
                elm_naviframe_item_pop(ad->navi);
-       } else if (APPMGRUG_TAB_DISABLED == ad->tabtype) {
+       else if (APPMGRUG_TAB_DISABLED == ad->tabtype)
                elm_object_disabled_set(obj, EINA_TRUE);
-       }
 
        setting_view_update(ad->main_view, ad);
 }

diff --git a/setting-appmgr/src/setting-appmgr-utils.c b/setting-appmgr/src/setting-appmgr-utils.c
index becb2f305fed6cc956db38bcfdb22241d0166779..aef8a72cf5f3d3fbf8607a52a5dc8db767c9aa18 100644 (file)
--- a/setting-appmgr/src/setting-appmgr-utils.c
+++ b/setting-appmgr/src/setting-appmgr-utils.c
@@ -76,9 +76,8 @@ Eina_Bool appmgrUg_get_app_size(void *data)
 
        int ret = package_manager_get_package_size_info(info->pkgid,
                _get_size_cb, info);
-       if (ret != 0) {
+       if (ret != 0)
                SETTING_TRACE_ERROR("failed to invoke ret = %d", ret);
-       }
 
        return EINA_FALSE;
 }
@@ -873,9 +872,7 @@ Evas_Object *appmgrUg_info_2button1_gl_icon_get(void *data, Evas_Object *obj,
        Evas_Object *button2 = NULL;
 
        setting_retvm_if(ad == NULL, NULL, "Data parameter is NULL");
-       if (0 != safeStrCmp(part, "elm.swallow.content")) {
-               return NULL;
-       }
+       retv_if(0 != safeStrCmp(part, "elm.swallow.content"), NULL);
        setting_retvm_if(ad->pkginfo == NULL, NULL, "ad->pkginfo is NULL");
        info = ad->pkginfo;
 
@@ -896,9 +893,8 @@ Evas_Object *appmgrUg_info_2button1_gl_icon_get(void *data, Evas_Object *obj,
                ret = app_manager_is_running(appid, &running_flag);
                warn_if(APP_MANAGER_ERROR_NONE != ret,
                                "app_manager_is_running Fail(%d)", ret);
-               if (running_flag) {
+               if (running_flag)
                        break;
-               }
        }
 
        button1 = setting_create_button(box, MGRAPP_STR_FORCE_STOP,
@@ -1035,9 +1031,8 @@ Evas_Object *appmgrUg_info_1button_gl_icon_get(void *data, Evas_Object *obj,
                        MGRAPP_STR_CLEAR_CACHE, NULL,
                        appmgrUg_pkg_clear_cache_click, ad);
 
-       if (info->sz_cache <= 0) {
+       if (info->sz_cache <= 0)
                elm_object_disabled_set(button1, EINA_TRUE);
-       }
 
        /* Fake button to reserve space after button1 */
        Evas_Object *button2 = setting_create_button(box, "BLANK", NULL, NULL,

diff --git a/setting-appmgr/src/setting-appmgr.c b/setting-appmgr/src/setting-appmgr.c
index 6bdf342d54858a107fe1c5fa8c65a6e97eeae82c..c2d54dae660f0190188862d15ded57553239457c 100644 (file)
--- a/setting-appmgr/src/setting-appmgr.c
+++ b/setting-appmgr/src/setting-appmgr.c
@@ -51,9 +51,8 @@ static void _app_mgr_item_del(void *data, Evas_Object *obj)
        setting_retm_if(data == NULL, "Data parameter is NULL");
        Setting_GenGroupItem_Data *item_data =
        (Setting_GenGroupItem_Data *) data;
-       if (item_data) {
+       if (item_data)
                FREE(item_data);
-       }
 }
 #endif
 
@@ -161,9 +160,8 @@ static void _rot_changed_cb(void *data, Evas_Object *obj, void *event_info)
 {
        SETTING_TRACE_BEGIN;
        SettingAppMgrUG *ad = (SettingAppMgrUG *)data;
-       if (ad == NULL || ad->win == NULL) {
-               return;
-       }
+       ret_if(ad == NULL || ad->win == NULL);
+
        int change_ang = elm_win_rotation_get(ad->win);
        SETTING_TRACE_DEBUG("....change_ang:%d", change_ang);
        SETTING_TRACE_DEBUG("current_rotation:%d", ad->current_rotation);
@@ -190,17 +188,17 @@ static void _rot_changed_cb(void *data, Evas_Object *obj, void *event_info)
 
        if (change_ang != ad->current_rotation) {
                int diff = change_ang - ad->current_rotation;
-               if (diff < 0) {
+               if (diff < 0)
                        diff = -diff;
-               }
+
                /**
                 * @todo if app didn't launch UG, is the call required to
                 * invoke?
                 */
                ug_send_event(event);
-               if (diff == 180) {
-                       /* do nothing */
-               }
+               /* if (diff == 180) {
+                       do nothing
+               } */
                ad->current_rotation = change_ang;
        }
 }