rtw89: pci: correct return value handling of rtw89_write16_mdio_mask()
authorPing-Ke Shih <pkshih@realtek.com>
Wed, 13 Apr 2022 01:08:04 +0000 (09:08 +0800)
committerKalle Valo <kvalo@kernel.org>
Wed, 13 Apr 2022 06:26:52 +0000 (09:26 +0300)
Fix wrong checking statement. Fortunately, this wrong code doesn't affect
existing chip.

Fixes: 740c431c22fe ("rtw89: pci: add register definition to rtw89_pci_info to generalize pci code")
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220413010804.8941-5-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/pci.c

index dcf907b..ecb4190 100644 (file)
@@ -1522,7 +1522,7 @@ rtw89_write16_mdio_mask(struct rtw89_dev *rtwdev, u8 addr, u16 mask, u16 data, u
        u16 val;
 
        ret = rtw89_read16_mdio(rtwdev, addr, speed, &val);
-       if (!ret)
+       if (ret)
                return ret;
 
        shift = __ffs(mask);
@@ -1530,7 +1530,7 @@ rtw89_write16_mdio_mask(struct rtw89_dev *rtwdev, u8 addr, u16 mask, u16 data, u
        val |= ((data << shift) & mask);
 
        ret = rtw89_write16_mdio(rtwdev, addr, val, speed);
-       if (!ret)
+       if (ret)
                return ret;
 
        return 0;