drm/amdgpu: fix scratch register access method in SRIOV
authorGavin Wan <Gavin.Wan@amd.com>
Mon, 18 Jul 2022 19:30:51 +0000 (15:30 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 20 Jul 2022 20:03:53 +0000 (16:03 -0400)
The scratch register should be accessed through MMIO instead of RLCG
in SRIOV, since it being used in RLCG register access function.

Fixes: d54762cc3e6a ("drm/amdgpu: nuke dynamic gfx scratch reg allocation")
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Gavin Wan <Gavin.Wan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c

index 5349ca4d19e38badd7da2d3b6a6073305e629c8f..c6e0f9313a7f79124db898639935bad6d6ae13c5 100644 (file)
@@ -987,23 +987,23 @@ static void gfx_v9_0_wait_reg_mem(struct amdgpu_ring *ring, int eng_sel,
 static int gfx_v9_0_ring_test_ring(struct amdgpu_ring *ring)
 {
        struct amdgpu_device *adev = ring->adev;
+       uint32_t scratch = SOC15_REG_OFFSET(GC, 0, mmSCRATCH_REG0);
        uint32_t tmp = 0;
        unsigned i;
        int r;
 
-       WREG32_SOC15(GC, 0, mmSCRATCH_REG0, 0xCAFEDEAD);
+       WREG32(scratch, 0xCAFEDEAD);
        r = amdgpu_ring_alloc(ring, 3);
        if (r)
                return r;
 
        amdgpu_ring_write(ring, PACKET3(PACKET3_SET_UCONFIG_REG, 1));
-       amdgpu_ring_write(ring, SOC15_REG_OFFSET(GC, 0, mmSCRATCH_REG0) -
-                         PACKET3_SET_UCONFIG_REG_START);
+       amdgpu_ring_write(ring, scratch - PACKET3_SET_UCONFIG_REG_START);
        amdgpu_ring_write(ring, 0xDEADBEEF);
        amdgpu_ring_commit(ring);
 
        for (i = 0; i < adev->usec_timeout; i++) {
-               tmp = RREG32_SOC15(GC, 0, mmSCRATCH_REG0);
+               tmp = RREG32(scratch);
                if (tmp == 0xDEADBEEF)
                        break;
                udelay(1);