Fix static analyzer issues

Change-Id: I3eab39f1c84b0b96d91834f0da8b5bf75394321f
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
(cherry picked from commit 57aa1da804676bb787363e8f0c0b0005fc01ef26)

diff --git a/src/common/recovery_file.cc b/src/common/recovery_file.cc
index 9d35299..4d988b8 100644 (file)
--- a/src/common/recovery_file.cc
+++ b/src/common/recovery_file.cc
@@ -82,7 +82,7 @@ std::unique_ptr<RecoveryFile> RecoveryFile::OpenRecoveryFileForPath(
 }
 
 RecoveryFile::RecoveryFile(const bf::path& path, bool load)
-    : path_(path) {
+    : type_(RequestType::Unknown), path_(path) {
   if (load) {
     if (!ReadFileContent()) {
       path_.clear();

diff --git a/src/common/utils/file_util.cc b/src/common/utils/file_util.cc
index 7935e9e..2a1f380 100644 (file)
--- a/src/common/utils/file_util.cc
+++ b/src/common/utils/file_util.cc
@@ -473,6 +473,7 @@ bool ExtractToTmpDir(const char* zip_path, const bf::path& tmp_dir,
           ret = unzReadCurrentFile(zip_file.Get(), read_buffer, kZipBufSize);
           if (ret < 0) {
             LOG(ERROR) << "Failed to read data: " << ret;
+            fclose(out);
             return false;
           } else {
             fwrite(read_buffer, sizeof(char), ret, out);