projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b6cacaf
)
scsi: isci: Remove the unneeded variable "status"
author
YANG LI
<abaci-bugfix@linux.alibaba.com>
Wed, 30 Dec 2020 07:04:20 +0000
(15:04 +0800)
committer
Martin K. Petersen
<martin.petersen@oracle.com>
Wed, 13 Jan 2021 04:34:06 +0000
(23:34 -0500)
The variable 'status' is being initialized with SCI_SUCCESS and never
updated later with a new value. The initialization is redundant and can be
removed.
Link:
https://lore.kernel.org/r/1609311860-102820-1-git-send-email-abaci-bugfix@linux.alibaba.com
Reported-by: Abaci <abaci@linux.alibaba.com>
Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/isci/request.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/isci/request.c
b/drivers/scsi/isci/request.c
index
6e08179
..
bee1685
100644
(file)
--- a/
drivers/scsi/isci/request.c
+++ b/
drivers/scsi/isci/request.c
@@
-2103,8
+2103,6
@@
sci_io_request_frame_handler(struct isci_request *ireq,
static enum sci_status stp_request_udma_await_tc_event(struct isci_request *ireq,
u32 completion_code)
{
- enum sci_status status = SCI_SUCCESS;
-
switch (SCU_GET_COMPLETION_TL_STATUS(completion_code)) {
case SCU_MAKE_COMPLETION_STATUS(SCU_TASK_DONE_GOOD):
ireq->scu_status = SCU_TASK_DONE_GOOD;
@@
-2148,7
+2146,7
@@
static enum sci_status stp_request_udma_await_tc_event(struct isci_request *ireq
break;
}
- return
status
;
+ return
SCI_SUCCESS
;
}
static enum sci_status atapi_raw_completion(struct isci_request *ireq, u32 completion_code,