lib: utils/serial: remove semihosting_putc

For some debuggers that do not implement SYSWRITEC and SYSREADC
operations, we have to use SYSWRITE and SYSREAD.

Instead of implementing semihosting_putc() using SYSWRITE, let us
simply remove semihosting_putc() because console_putc/console_puts
are now interchangeable.

Signed-off-by: Chen Pei <cp0613@linux.alibaba.com>
Signed-off-by: Xiang W <wxjstz@126.com>
Reviewed-by: Guo Ren <guoren@kernel.org>
Reviewed-by: Anup Patel <anup@brainfault.org>

diff --git a/lib/utils/serial/semihosting.c b/lib/utils/serial/semihosting.c
index a27c69eed81721cf57f0597cd9d5a2f5f2cf1c24..19ebaa07e3414a5ba496d2cc5446b696e16da638 100644 (file)
--- a/lib/utils/serial/semihosting.c
+++ b/lib/utils/serial/semihosting.c
@@ -178,11 +178,6 @@ static unsigned long semihosting_puts(const char *str, unsigned long len)
        return (ret < 0) ? 0 : ret;
 }
 
-static void semihosting_putc(char ch)
-{
-       semihosting_puts(&ch, 1);
-}
-
 static int semihosting_getc(void)
 {
        char ch = 0;
@@ -199,7 +194,6 @@ static int semihosting_getc(void)
 
 static struct sbi_console_device semihosting_console = {
        .name = "semihosting",
-       .console_putc = semihosting_putc,
        .console_puts = semihosting_puts,
        .console_getc = semihosting_getc
 };