spi: orion: Add of_node_put() before goto
authorWan Jiabing <wanjiabing@vivo.com>
Fri, 15 Oct 2021 03:40:08 +0000 (23:40 -0400)
committerMark Brown <broonie@kernel.org>
Fri, 15 Oct 2021 15:10:59 +0000 (16:10 +0100)
Fix following coccicheck warning:
./drivers/spi/spi-orion.c:738:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before goto

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20211015034008.6357-1-wanjiabing@vivo.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-orion.c

index e8de3cb..565cd4c 100644 (file)
@@ -769,6 +769,7 @@ static int orion_spi_probe(struct platform_device *pdev)
                dir_acc->vaddr = devm_ioremap(&pdev->dev, r->start, PAGE_SIZE);
                if (!dir_acc->vaddr) {
                        status = -ENOMEM;
+                       of_node_put(np);
                        goto out_rel_axi_clk;
                }
                dir_acc->size = PAGE_SIZE;