irqchip/loongson-htvec: Check return value of irq_domain_translate_onecell()
authorTiezhu Yang <yangtiezhu@loongson.cn>
Tue, 7 Jul 2020 02:12:48 +0000 (10:12 +0800)
committerMarc Zyngier <maz@kernel.org>
Fri, 17 Jul 2020 12:41:42 +0000 (13:41 +0100)
Check the return value of irq_domain_translate_onecell() due to
it may returns -EINVAL if failed.

Fixes: 818e915fbac5 ("irqchip: Add Loongson HyperTransport Vector support")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/1594087972-21715-5-git-send-email-yangtiezhu@loongson.cn
drivers/irqchip/irq-loongson-htvec.c

index b36d403..720cf96 100644 (file)
@@ -109,11 +109,14 @@ static struct irq_chip htvec_irq_chip = {
 static int htvec_domain_alloc(struct irq_domain *domain, unsigned int virq,
                              unsigned int nr_irqs, void *arg)
 {
+       int ret;
        unsigned long hwirq;
        unsigned int type, i;
        struct htvec *priv = domain->host_data;
 
-       irq_domain_translate_onecell(domain, arg, &hwirq, &type);
+       ret = irq_domain_translate_onecell(domain, arg, &hwirq, &type);
+       if (ret)
+               return ret;
 
        for (i = 0; i < nr_irqs; i++) {
                irq_domain_set_info(domain, virq + i, hwirq + i, &htvec_irq_chip,