Remove useless & unsafe unlock/lock code 99/303699/3 accepted/tizen_unified_riscv accepted/tizen/unified/20240105.165031 accepted/tizen/unified/20240226.134013 accepted/tizen/unified/riscv/20240108.035927 accepted/tizen/unified/x/20240226.135043
authorjinbong, Lee <jinbong.lee@samsung.com>
Wed, 3 Jan 2024 11:34:09 +0000 (11:34 +0000)
committerJinbong Lee <jinbong.lee@samsung.com>
Wed, 3 Jan 2024 11:51:47 +0000 (11:51 +0000)
 - there is no blocking function in tizen_window_enqueue_buffer_with_damage
 - So there is no blocking to other EGL calls
 - In additionally, it can cause some broken situation in multi-threaded egl api call,
 - because of display's Mutex protection is not working during unlocked time.

Change-Id: Ib683a8478b5ba1a8f855f675d70407e5b34bd26c

src/egl/drivers/dri2/platform_tizen.c

index 37ecaa6..64bb7f9 100755 (executable)
@@ -297,12 +297,6 @@ tizen_window_enqueue_buffer_with_damage(_EGLDisplay *disp,
    struct dri2_egl_display *dri2_dpy = dri2_egl_display(disp);
    int fence_fd = -1;
 
-   /* To avoid blocking other EGL calls, release the display mutex before
-    * we enter tizen_window_enqueue_buffer() and re-acquire the mutex upon
-    * return.
-    */
-   simple_mtx_unlock(&disp->Mutex);
-
    fence_fd = dri2_surf->out_fence_fd;
 
    if (fence_fd >= 0 && dri2_surf->is_frontbuffer_mode) {
@@ -325,8 +319,6 @@ tizen_window_enqueue_buffer_with_damage(_EGLDisplay *disp,
    dri2_surf->tbm_surface = NULL;
    dri2_surf->back = NULL;
 
-   simple_mtx_lock(&disp->Mutex);
-
    if (dri2_surf->dri_image_back) {
       dri2_dpy->image->destroyImage(dri2_surf->dri_image_back);
       dri2_surf->dri_image_back = NULL;