platform/mellanox: mlxreg-io: Fix read access of n-bytes size attributes
authorVadim Pasternak <vadimp@nvidia.com>
Mon, 27 Sep 2021 14:22:14 +0000 (17:22 +0300)
committerHans de Goede <hdegoede@redhat.com>
Mon, 11 Oct 2021 12:57:22 +0000 (14:57 +0200)
Fix shift argument for function rol32(). It should be provided in bits,
while was provided in bytes.

Fixes: 86148190a7db ("platform/mellanox: mlxreg-io: Add support for complex attributes")
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
Link: https://lore.kernel.org/r/20210927142214.2613929-3-vadimp@nvidia.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/mellanox/mlxreg-io.c

index a023ec0..a916cd8 100644 (file)
@@ -98,7 +98,7 @@ mlxreg_io_get_reg(void *regmap, struct mlxreg_core_data *data, u32 in_val,
                        if (ret)
                                goto access_error;
 
-                       *regval |= rol32(val, regsize * i);
+                       *regval |= rol32(val, regsize * i * 8);
                }
        }