Documentation updates.

git-svn-id: http://libphonenumber.googlecode.com/svn/trunk@24 ee073f10-1060-11df-b6a4-87a95322a99c

diff --git a/java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java b/java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java
index c9e0dadf297dfa2fda140550b7b202f030d11072..5feefdd135663bb0c84b5350aa95cf32aeecc0b5 100644 (file)
--- a/java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java
+++ b/java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java
@@ -59,11 +59,14 @@ public class PhoneNumberUtil {
   // represented by that country code. Note countries under NANPA share the country code 1,
   // Russia and Kazakhstan share the country code 7, and many French territories in the Indian
   // Ocean share the country code 262. Under this map, 1 is mapped to US, 7 is mapped to RU,
-  // and 262 is mapped to RE.
-  private final HashMap<Integer, String> countryCodeToRegionCodeMap = new HashMap<Integer, String>(200);
-
-  // The set of countries that share country code 1.
-  private final HashSet<String> nanpaCountries = new HashSet<String>(30);
+  // and 262 is mapped to RE. The initial capacity is set to 300 as there are roughly 200 different
+  // country codes, and this offers a load factor of roughly 0.75.
+  private final HashMap<Integer, String> countryCodeToRegionCodeMap =
+      new HashMap<Integer, String>(310);
+
+  // The set of countries that share country code 1. There are roughly 26 countries of them and we
+  // set the initial capacity of the HashSet to 35 to offer a load factor of roughly 0.75.
+  private final HashSet<String> nanpaCountries = new HashSet<String>(35);
   private static final int NANPA_COUNTRY_CODE = 1;
 
   // The set of countries that share country code 7.
@@ -280,7 +283,9 @@ public class PhoneNumberUtil {
   private HashMap<String, PhoneMetadata> countryToMetadataMap =
       new HashMap<String, PhoneMetadata>();
 
-  // A cache for frequently used regular expressions.
+  // A cache for frequently used regular expressions. As most people use phone numbers primarily
+  // from one country, and there are roughly 30 regular expressions needed, the initial capacity of
+  // 50 offers a rough load factor of 0.75.
   private RegexCache regexCache = new RegexCache(50);
 
   /**

diff --git a/java/src/com/google/i18n/phonenumbers/RegexCache.java b/java/src/com/google/i18n/phonenumbers/RegexCache.java
index 8c4f8dea0fda1d25925482e1e02c978ee9fb95cc..683b876296ae43d72909feaef6f4b9be36792976 100644 (file)
--- a/java/src/com/google/i18n/phonenumbers/RegexCache.java
+++ b/java/src/com/google/i18n/phonenumbers/RegexCache.java
@@ -34,20 +34,21 @@ public class RegexCache {
   }
 
   public Pattern getPatternForRegex(String regex) {
-    if (containsRegex(regex)) {
-      return cache.get(regex);
-    } else {
-      Pattern pattern = Pattern.compile(regex);
+    Pattern pattern = cache.get(regex);
+    if (pattern == null) {
+      pattern = Pattern.compile(regex);
       cache.put(regex, pattern);
-      return pattern;
     }
+    return pattern;
   }
 
+  // This method is used for testing.
   boolean containsRegex(String regex) {
     return cache.containsKey(regex);
   }
 
   private class LRUCache<K, V> {
+    // LinkedHashMap offers a straightforward implementation of LRU cache.
     private LinkedHashMap<K, V> map;
     private int size;