projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
daf6e8c
)
net: sgi: ioc3-eth: check return value after calling platform_get_resource()
author
Yang Yingliang
<yangyingliang@huawei.com>
Wed, 9 Jun 2021 13:25:15 +0000
(21:25 +0800)
committer
David S. Miller
<davem@davemloft.net>
Wed, 9 Jun 2021 22:24:43 +0000
(15:24 -0700)
It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sgi/ioc3-eth.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/sgi/ioc3-eth.c
b/drivers/net/ethernet/sgi/ioc3-eth.c
index
6eef0f4
..
2b29fd4
100644
(file)
--- a/
drivers/net/ethernet/sgi/ioc3-eth.c
+++ b/
drivers/net/ethernet/sgi/ioc3-eth.c
@@
-835,6
+835,10
@@
static int ioc3eth_probe(struct platform_device *pdev)
int err;
regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!regs) {
+ dev_err(&pdev->dev, "Invalid resource\n");
+ return -EINVAL;
+ }
/* get mac addr from one wire prom */
if (ioc3eth_get_mac_addr(regs, mac_addr))
return -EPROBE_DEFER; /* not available yet */