scsi: ufs: ufshcd: Do not set COMMAND_COMPLETE
authorHannes Reinecke <hare@suse.de>
Wed, 13 Jan 2021 09:04:48 +0000 (10:04 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 23 Jan 2021 02:14:11 +0000 (21:14 -0500)
COMMAND_COMPLETE is defined as '0', so setting it is quite pointless.

Link: https://lore.kernel.org/r/20210113090500.129644-24-hare@suse.de
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c

index 9c691e4..69a8a4e 100644 (file)
@@ -4911,9 +4911,7 @@ ufshcd_scsi_cmd_status(struct ufshcd_lrb *lrbp, int scsi_status)
                ufshcd_copy_sense_data(lrbp);
                fallthrough;
        case SAM_STAT_GOOD:
-               result |= DID_OK << 16 |
-                         COMMAND_COMPLETE << 8 |
-                         scsi_status;
+               result |= DID_OK << 16 | scsi_status;
                break;
        case SAM_STAT_TASK_SET_FULL:
        case SAM_STAT_BUSY: