mtd: rawnand: macronix: Use match_string() helper to simplify the code
authorYueHaibing <yuehaibing@huawei.com>
Tue, 31 Dec 2019 01:36:48 +0000 (09:36 +0800)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 21 Jan 2020 19:00:34 +0000 (20:00 +0100)
match_string() returns the array index of a matching string.
Use it instead of the open-coded implementation.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/raw/nand_macronix.c

index 58511ae..3ff7ce0 100644 (file)
@@ -59,7 +59,7 @@ static void macronix_nand_onfi_init(struct nand_chip *chip)
  */
 static void macronix_nand_fix_broken_get_timings(struct nand_chip *chip)
 {
-       unsigned int i;
+       int i;
        static const char * const broken_get_timings[] = {
                "MX30LF1G18AC",
                "MX30LF1G28AC",
@@ -80,12 +80,9 @@ static void macronix_nand_fix_broken_get_timings(struct nand_chip *chip)
        if (!chip->parameters.supports_set_get_features)
                return;
 
-       for (i = 0; i < ARRAY_SIZE(broken_get_timings); i++) {
-               if (!strcmp(broken_get_timings[i], chip->parameters.model))
-                       break;
-       }
-
-       if (i == ARRAY_SIZE(broken_get_timings))
+       i = match_string(broken_get_timings, ARRAY_SIZE(broken_get_timings),
+                        chip->parameters.model);
+       if (i < 0)
                return;
 
        bitmap_clear(chip->parameters.get_feature_list,