v3dv: honor VkPipelineDepthStencilStateCreateInfo::depthWriteEnable
authorIago Toral Quiroga <itoral@igalia.com>
Wed, 9 Sep 2020 07:18:43 +0000 (09:18 +0200)
committerMarge Bot <eric+marge@anholt.net>
Tue, 13 Oct 2020 21:21:33 +0000 (21:21 +0000)
Fixes:
dEQP-VK.renderpass.suballocation.subpass_dependencies.separate_channels.d24_unorm_s8_uint

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6766>

src/broadcom/vulkan/v3dv_pipeline.c

index 0589a93..9916d65 100644 (file)
@@ -2353,7 +2353,7 @@ pack_cfg_bits(struct v3dv_pipeline *pipeline,
          pipeline->subpass->ds_attachment.attachment != VK_ATTACHMENT_UNUSED;
 
       if (ds_info && ds_info->depthTestEnable && has_ds_attachment) {
-         config.z_updates_enable = true;
+         config.z_updates_enable = ds_info->depthWriteEnable;
          config.depth_test_function = ds_info->depthCompareOp;
       } else {
          config.depth_test_function = VK_COMPARE_OP_ALWAYS;