drm/mi0283qt: Avoid spamming logs if probe is deferred
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 21 Apr 2021 16:31:53 +0000 (19:31 +0300)
committerNoralf Trønnes <noralf@tronnes.org>
Tue, 27 Apr 2021 11:14:06 +0000 (13:14 +0200)
The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210421163157.50949-3-andriy.shevchenko@linux.intel.com
drivers/gpu/drm/tiny/mi0283qt.c

index dc76fe5..82fd1ad 100644 (file)
@@ -196,16 +196,12 @@ static int mi0283qt_probe(struct spi_device *spi)
        drm = &dbidev->drm;
 
        dbi->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
-       if (IS_ERR(dbi->reset)) {
-               DRM_DEV_ERROR(dev, "Failed to get gpio 'reset'\n");
-               return PTR_ERR(dbi->reset);
-       }
+       if (IS_ERR(dbi->reset))
+               return dev_err_probe(dev, PTR_ERR(dbi->reset), "Failed to get GPIO 'reset'\n");
 
        dc = devm_gpiod_get_optional(dev, "dc", GPIOD_OUT_LOW);
-       if (IS_ERR(dc)) {
-               DRM_DEV_ERROR(dev, "Failed to get gpio 'dc'\n");
-               return PTR_ERR(dc);
-       }
+       if (IS_ERR(dc))
+               return dev_err_probe(dev, PTR_ERR(dc), "Failed to get GPIO 'dc'\n");
 
        dbidev->regulator = devm_regulator_get(dev, "power");
        if (IS_ERR(dbidev->regulator))