clk: qcom: gcc-sc8280xp: Allow PCIe GDSCs to enter retention state
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Fri, 7 Jul 2023 07:59:26 +0000 (13:29 +0530)
committerBjorn Andersson <andersson@kernel.org>
Mon, 10 Jul 2023 04:47:28 +0000 (21:47 -0700)
With the minimal system suspend support in place for the PCIe driver that
keeps the interconnect path voted, the ALWAYS_ON flag can now be dropped.

Also, the pwrsts PWRSTS_RET_ON flag should be used to allow the GDSCs to
enter the retention state when the parent domain get's turned off during
system suspend.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20230707075926.11726-1-manivannan.sadhasivam@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/clk/qcom/gcc-sc8280xp.c

index 3e1a62f..1fb6ffa 100644 (file)
@@ -6786,8 +6786,8 @@ static struct gdsc pcie_2a_gdsc = {
        .pd = {
                .name = "pcie_2a_gdsc",
        },
-       .pwrsts = PWRSTS_OFF_ON,
-       .flags = VOTABLE | RETAIN_FF_ENABLE | ALWAYS_ON,
+       .pwrsts = PWRSTS_RET_ON,
+       .flags = VOTABLE | RETAIN_FF_ENABLE,
 };
 
 static struct gdsc pcie_2b_gdsc = {
@@ -6797,8 +6797,8 @@ static struct gdsc pcie_2b_gdsc = {
        .pd = {
                .name = "pcie_2b_gdsc",
        },
-       .pwrsts = PWRSTS_OFF_ON,
-       .flags = VOTABLE | RETAIN_FF_ENABLE | ALWAYS_ON,
+       .pwrsts = PWRSTS_RET_ON,
+       .flags = VOTABLE | RETAIN_FF_ENABLE,
 };
 
 static struct gdsc pcie_3a_gdsc = {
@@ -6808,8 +6808,8 @@ static struct gdsc pcie_3a_gdsc = {
        .pd = {
                .name = "pcie_3a_gdsc",
        },
-       .pwrsts = PWRSTS_OFF_ON,
-       .flags = VOTABLE | RETAIN_FF_ENABLE | ALWAYS_ON,
+       .pwrsts = PWRSTS_RET_ON,
+       .flags = VOTABLE | RETAIN_FF_ENABLE,
 };
 
 static struct gdsc pcie_3b_gdsc = {
@@ -6819,8 +6819,8 @@ static struct gdsc pcie_3b_gdsc = {
        .pd = {
                .name = "pcie_3b_gdsc",
        },
-       .pwrsts = PWRSTS_OFF_ON,
-       .flags = VOTABLE | RETAIN_FF_ENABLE | ALWAYS_ON,
+       .pwrsts = PWRSTS_RET_ON,
+       .flags = VOTABLE | RETAIN_FF_ENABLE,
 };
 
 static struct gdsc pcie_4_gdsc = {
@@ -6830,8 +6830,8 @@ static struct gdsc pcie_4_gdsc = {
        .pd = {
                .name = "pcie_4_gdsc",
        },
-       .pwrsts = PWRSTS_OFF_ON,
-       .flags = VOTABLE | RETAIN_FF_ENABLE | ALWAYS_ON,
+       .pwrsts = PWRSTS_RET_ON,
+       .flags = VOTABLE | RETAIN_FF_ENABLE,
 };
 
 static struct gdsc ufs_card_gdsc = {