Fix Crossgen2 test concurrency on Windows (#45433)
authorTomáš Rylek <trylek@microsoft.com>
Tue, 1 Dec 2020 23:17:23 +0000 (00:17 +0100)
committerGitHub <noreply@github.com>
Tue, 1 Dec 2020 23:17:23 +0000 (00:17 +0100)
In my previous attempt at fixing the test concurrency w.r.t. to
multiple "RunOnly" tests exercising the same "BuildAndRun"
executable compiled with Crossgen2,

https://github.com/dotnet/runtime/pull/44492

I have apparently used the wrong escaping in the batch (cmd)
version of the script so that the fix doesn't work on Windows.
This change is fixing this deficiency.

Thanks

Tomas

src/tests/Common/CLRTest.CrossGen.targets

index 96c6c31..7c31fb4 100644 (file)
@@ -220,7 +220,7 @@ if defined RunCrossGen2 (
     if exist "IL-CG2" (
       REM We may have come in the middle of a concurrent CG2 compilation, wait for it to finish
       :ProbeCompilationFinished
-      if exist "%%compilationDoneFlagFile%%" goto :DoneCrossgen2OperationsNoRelease
+      if exist "!compilationDoneFlagFile!" goto :DoneCrossgen2OperationsNoRelease
       echo Waiting for concurrent Crossgen2 compilation^: !compilationDoneFlagFile!
       timeout /t 5 /nobreak
       goto :ProbeCompilationFinished