gtk/gl: Only unbind buffers/vertex attrib arrays if we can't directly bind the vertex...
authorSebastian Dröge <sebastian@centricular.com>
Wed, 16 Jan 2019 12:11:44 +0000 (14:11 +0200)
committerSebastian Dröge <sebastian@centricular.com>
Wed, 16 Jan 2019 12:11:44 +0000 (14:11 +0200)
Binding the vertex array to 0 will unbind everything else already.

In the previous order older versions of the Intel GL driver caused
errors to be printed for every single call when disabling the vertex
attrib arrays after binding the vertex array to 0.

ext/gtk/gtkgstglwidget.c

index 2a8beab..8381c21 100644 (file)
@@ -200,7 +200,8 @@ _redraw_texture (GtkGstGLWidget * gst_widget, guint tex)
 
   if (gl->BindVertexArray)
     gl->BindVertexArray (0);
-  gtk_gst_gl_widget_unbind_buffer (gst_widget);
+  else
+    gtk_gst_gl_widget_unbind_buffer (gst_widget);
 
   gl->BindTexture (GL_TEXTURE_2D, 0);
 }