ath11k: fix rcu lock protect in peer assoc confirmation
authorKarthikeyan Periyasamy <periyasa@codeaurora.org>
Wed, 5 Feb 2020 01:22:28 +0000 (06:52 +0530)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 11 Feb 2020 18:31:19 +0000 (20:31 +0200)
ath11k_mac_get_ar_by_vdev_id() get protected under rcu lock
and unlock. peer association confirmation event get used this API
without rcu protection, so corrected it.

Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath11k/wmi.c

index a9b301c..9cbe038 100644 (file)
@@ -5345,15 +5345,18 @@ static void ath11k_peer_assoc_conf_event(struct ath11k_base *ab, struct sk_buff
                   "peer assoc conf ev vdev id %d macaddr %pM\n",
                   peer_assoc_conf.vdev_id, peer_assoc_conf.macaddr);
 
+       rcu_read_lock();
        ar = ath11k_mac_get_ar_by_vdev_id(ab, peer_assoc_conf.vdev_id);
 
        if (!ar) {
                ath11k_warn(ab, "invalid vdev id in peer assoc conf ev %d",
                            peer_assoc_conf.vdev_id);
+               rcu_read_unlock();
                return;
        }
 
        complete(&ar->peer_assoc_done);
+       rcu_read_unlock();
 }
 
 static void ath11k_update_stats_event(struct ath11k_base *ab, struct sk_buff *skb)