staging:rtl8192u: Remove potential memory leak
authorJohn Whitmore <johnfwhitmore@gmail.com>
Wed, 26 Sep 2018 19:17:04 +0000 (20:17 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Sep 2018 12:36:58 +0000 (14:36 +0200)
Add call to ieee80211_networks_free() to avoid potential memory
leak if allocation of pHTInfo fails.

If the third allocation fails only the first successful allocation
is freed, not the second.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

index 90a097f..aada077 100644 (file)
@@ -159,6 +159,11 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
        ieee->pHTInfo = kzalloc(sizeof(RT_HIGH_THROUGHPUT), GFP_KERNEL);
        if (ieee->pHTInfo == NULL) {
                IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc memory for HTInfo\n");
+
+               /* By this point in code ieee80211_networks_allocate() has been
+                * successfully called so the memory allocated should be freed
+                */
+               ieee80211_networks_free(ieee);
                goto failed;
        }
        HTUpdateDefaultSetting(ieee);