NFS: Have nfs4_proc_setclientid() call nfs4_call_sync_custom()
authorAnna Schumaker <Anna.Schumaker@Netapp.com>
Wed, 14 Aug 2019 19:28:28 +0000 (15:28 -0400)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Thu, 22 Aug 2019 14:05:11 +0000 (10:05 -0400)
Rather than running the task manually

Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/nfs4proc.c

index e5b6499c0b8b7c5dbe93d261023e0f93aa3e810c..234312240f33e92e7361d5fa2360852dcb3faf8a 100644 (file)
@@ -6023,7 +6023,6 @@ int nfs4_proc_setclientid(struct nfs_client *clp, u32 program,
                .rpc_resp = res,
                .rpc_cred = cred,
        };
-       struct rpc_task *task;
        struct rpc_task_setup task_setup_data = {
                .rpc_client = clp->cl_rpcclient,
                .rpc_message = &msg,
@@ -6056,17 +6055,12 @@ int nfs4_proc_setclientid(struct nfs_client *clp, u32 program,
        dprintk("NFS call  setclientid auth=%s, '%s'\n",
                clp->cl_rpcclient->cl_auth->au_ops->au_name,
                clp->cl_owner_id);
-       task = rpc_run_task(&task_setup_data);
-       if (IS_ERR(task)) {
-               status = PTR_ERR(task);
-               goto out;
-       }
-       status = task->tk_status;
+
+       status = nfs4_call_sync_custom(&task_setup_data);
        if (setclientid.sc_cred) {
                clp->cl_acceptor = rpcauth_stringify_acceptor(setclientid.sc_cred);
                put_rpccred(setclientid.sc_cred);
        }
-       rpc_put_task(task);
 out:
        trace_nfs4_setclientid(clp, status);
        dprintk("NFS reply setclientid: %d\n", status);